mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-10-09 15:58:34 +00:00
c6baebd514
* Support password in ssh deep links with ephemeral connect ssh://user:password@host URLs now connect directly using the URL credentials without saving the host to the vault, covering bastion one-time password flows. Password-less links keep the existing match-or-prefill behavior. Fixes #1890 Co-authored-by: Cursor <cursoragent@cursor.com> * Keep ephemeral deep-link hosts out of vault update paths Terminal-layer host updates (e.g. the SFTP follow-CWD toggle) map over the merged terminal host list, which could persist an ephemeral host and its plaintext password into the vault. Route terminal-layer host updates through a splitter that applies ephemeral entries to in-memory state only and forwards just the vault hosts to updateHosts. Co-authored-by: Cursor <cursoragent@cursor.com> * Exclude ephemeral deep-link sessions from session restore Sessions backed by an in-memory ephemeral host cannot survive a relaunch (the one-time password only lives in memory), so persisting them would leak the ephemeral host metadata into restore storage and restore a tab that can never reconnect. Mark ephemeral hosts and their sessions, and filter them out of the session-restore payload. Co-authored-by: Cursor <cursoragent@cursor.com> * Treat ephemeral hosts as unsaved in appearance classification The terminal theme/font panel and pane appearance resolution decided "saved vault host" via hostMap membership. Ephemeral deep-link hosts are now in that map, so theme/font changes were routed to the persisted-host updater and silently dropped. Classify via isSavedVaultHost (ephemeral flag aware) so those changes fall back to the session/global setting path as before. Co-authored-by: Cursor <cursoragent@cursor.com> * Reuse saved host settings for password deep links and keep ephemeral marker on clones Password deep links now run saved-host matching first: a uniquely matched vault host contributes its non-credential settings (proxy, jump chain, charset, group, ...) to the ephemeral host while the URL credentials override vault identities and key references. Session clones (split/copy/copy-to-new-window) now carry the ephemeralHost marker so cloned tabs stay excluded from session restore. Co-authored-by: Cursor <cursoragent@cursor.com> * Block group credential inheritance on password deep-link ephemeral hosts buildSshDeepLinkEphemeralHostFromSaved now takes the group-resolved effective host and clears group/identityFilePaths in addition to identity references, so a later resolveEffectiveHost pass cannot re-inherit group default credentials (identity, key, password) over the one-time URL password. Non-credential group defaults (proxy, jump chain, charset, ...) are preserved via the effective host. Co-authored-by: Cursor <cursoragent@cursor.com> * Route ephemeral-host font zoom through the per-session font-size path Ctrl+zoom on a non-workspace ephemeral deep-link session hit the saved-host update path, where the vault updater silently dropped the change (ephemeral ids are not in the persisted hosts array). Zoom and the theme panel font-size slider/reset now store the size on the session (rendered via applySessionFontSizeToHost) for ephemeral hosts, matching the workspace-pane behavior. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix ephemeral session font zoom routing * Prevent ephemeral deep-link sudo autofill --------- Co-authored-by: Cursor <cursoragent@cursor.com>
94 lines
3.2 KiB
TypeScript
94 lines
3.2 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import type { TerminalSession } from "../../domain/models";
|
|
import {
|
|
canReuseTerminalConnection,
|
|
createCopiedTerminalSessionClone,
|
|
createSplitTerminalSessionClone,
|
|
} from "./terminalConnectionReuse";
|
|
|
|
const session = (overrides: Partial<TerminalSession> = {}): TerminalSession => ({
|
|
id: "session-1",
|
|
hostId: "host-1",
|
|
hostLabel: "Host",
|
|
hostname: "example.com",
|
|
username: "alice",
|
|
status: "connected",
|
|
protocol: "ssh",
|
|
...overrides,
|
|
});
|
|
|
|
test("connected SSH sessions can reuse their authenticated connection", () => {
|
|
assert.equal(canReuseTerminalConnection(session()), true);
|
|
assert.equal(canReuseTerminalConnection(session({ protocol: undefined })), true);
|
|
});
|
|
|
|
test("non-SSH or unavailable sessions do not reuse a connection", () => {
|
|
assert.equal(canReuseTerminalConnection(session({ status: "connecting" })), false);
|
|
assert.equal(canReuseTerminalConnection(session({ status: "disconnected" })), false);
|
|
assert.equal(canReuseTerminalConnection(session({ protocol: "local" })), false);
|
|
assert.equal(canReuseTerminalConnection(session({ protocol: "serial" })), false);
|
|
assert.equal(canReuseTerminalConnection(session({ protocol: "telnet" })), false);
|
|
assert.equal(canReuseTerminalConnection(session({ moshEnabled: true })), false);
|
|
assert.equal(canReuseTerminalConnection(session({ etEnabled: true })), false);
|
|
});
|
|
|
|
test("split session clones reuse only connected SSH sources", () => {
|
|
assert.equal(
|
|
createSplitTerminalSessionClone(session(), { id: "split-1", workspaceId: "workspace-1" }).reuseConnectionFromSessionId,
|
|
"session-1",
|
|
);
|
|
assert.equal(
|
|
createSplitTerminalSessionClone(session({ etEnabled: true }), { id: "split-2" }).reuseConnectionFromSessionId,
|
|
undefined,
|
|
);
|
|
assert.equal(
|
|
createSplitTerminalSessionClone(session({ moshEnabled: true }), { id: "split-3" }).reuseConnectionFromSessionId,
|
|
undefined,
|
|
);
|
|
});
|
|
|
|
test("session clones preserve the ephemeral-host marker", () => {
|
|
assert.equal(
|
|
createSplitTerminalSessionClone(session({ ephemeralHost: true }), { id: "split-1" }).ephemeralHost,
|
|
true,
|
|
);
|
|
assert.equal(
|
|
createCopiedTerminalSessionClone(session({ ephemeralHost: true }), { id: "copy-1" }).ephemeralHost,
|
|
true,
|
|
);
|
|
assert.equal(
|
|
createSplitTerminalSessionClone(session(), { id: "split-2" }).ephemeralHost,
|
|
undefined,
|
|
);
|
|
});
|
|
|
|
test("copy session clones reuse SSH sources and preserve serial config", () => {
|
|
const copied = createCopiedTerminalSessionClone(
|
|
session({
|
|
serialConfig: { path: "/dev/tty.usbserial", baudRate: 115200 },
|
|
}),
|
|
{ id: "copy-1" },
|
|
);
|
|
|
|
assert.equal(copied.reuseConnectionFromSessionId, "session-1");
|
|
assert.deepEqual(copied.serialConfig, { path: "/dev/tty.usbserial", baudRate: 115200 });
|
|
});
|
|
|
|
test("split and copy session clones preserve local start directory", () => {
|
|
const source = session({
|
|
protocol: "local",
|
|
localStartDir: "/Users/alice/project with spaces ",
|
|
});
|
|
|
|
assert.equal(
|
|
createSplitTerminalSessionClone(source, { id: "split-local" }).localStartDir,
|
|
"/Users/alice/project with spaces ",
|
|
);
|
|
assert.equal(
|
|
createCopiedTerminalSessionClone(source, { id: "copy-local" }).localStartDir,
|
|
"/Users/alice/project with spaces ",
|
|
);
|
|
});
|