Files
Netcatty/components/terminalLayer/TerminalLayerSidePanelSection.tsx
T
陈大猫 6b9b71ac8a feat(scripts): terminal script automation, recording, and side panel (#1763)
* feat(scripts): add terminal script automation, recording, and side panel

Introduce nct script runtime in the main process with terminal-side recording,
execution overlay, Monaco editor, connect-script queues, and scripts side panel
integration. Fix recording to wire scriptRecorderRef into xterm, use waitForPrompt
for root/user shells, and save recorded scripts through the global editor dialog.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): address Bugbot review findings for recording and side panel

Refresh script run state in side panel memo, guard toolbar recording against
multi-session conflicts, reset connect scripts on reconnect, resolve focused
session via getActiveTerminalSessionId, and avoid wiping host edit form when
snippets list updates.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): prevent pending script re-run and improve workspace run feedback

Track one-shot pendingScript execution separately from onConnect queue so
reconnects do not replay Run-now scripts. Fall back to focused session when
running on all tabs outside a workspace, and toast when every tab is still
connecting.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): consume connect-script window once and filter serial hosts

Mark the onConnect script evaluation as consumed even when the queue is
empty so later snippet/host edits do not rerun automation mid-session.
Restore serial-host filtering in SelectHostPanel confirm handler.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): grace period before giving up on connect-script queue

Only mark onConnect automation as consumed after scripts run or a short
post-connect grace window expires, so late-loading snippets still trigger
while mid-session Vault edits do not.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): gate connect-script consumption on vault hydration

Replace the grace timer with vault-init and unresolved host script binding
checks so late-loading snippets still run onConnect automation while
mid-session edits stay suppressed. Clear pending script run state on
disconnect so reconnect retries workspace pending scripts.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): honor run targets and retry failed connect automation

Route QuickScriptEditorDialog Run through onRunSnippet for multi-host
workspaces. Defer connect/pending script completion markers until each
script succeeds and retry the queue after failures.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): stabilize pending runs and global connect queue sync

Keep pending script run state across reconnects, run onConnect scripts
before one-shot workspace pending scripts, and strip per-host queue entries
when an onConnect script targets all hosts.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): defer host queue snippet sync and guard connect runs

Persist snippet target links only when the host panel is saved, block
duplicate connect-script scheduling while a batch is running, and require
runnable hosts before showing Run in the snippets editor footer.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): retry connect failures and surface output-trigger errors

Use a retry tick in connect-script effect deps, toast automation failures
from output triggers, and require runnable hosts before QuickScript Run.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): track id-less pending runs and re-arm output triggers

Remember anonymous pendingScript objects after first run and allow
onOutput triggers to fire again when new terminal output arrives.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): unblock paused connect runs and pass session meta

Resolve waitForScriptRun on pause, run workspace scripts per session
with hostname context, defer output-trigger arming until runs start, and
add noRunnableHosts i18n for QuickScript Run.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): serialize output triggers and defer empty connect finalize

Fire at most one onOutput trigger per scan while a run is active, and
only finalize an empty connect queue after vault snippets are loaded.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): guard output launch race and script run waits

Block overlapping onOutput launches, timeout stuck waitForScriptRun
promises, and disable vault Run when no connectable targets exist.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): match output triggers on new chunks only

Scan onOutput patterns against recent terminal output instead of buffer
length dedupe, and restore overflow-visible on SelectHostPanel new-host flow.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): await sequential workspace runs and output launch

Wait for each tab script to finish in sequential workspace mode, and hold
output-trigger launch guard until the session run becomes active.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): wait through pause and hold output trigger until done

Keep connect and sequential workspace queues blocked until scripts
complete or fail, and retain output-trigger guard until the launched run
finishes.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): harden output trigger wait helpers

Add explicit timeouts to output-trigger wait helpers and stop rescanning
the buffer after script completion to avoid sticky-match rerun loops.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): allow empty connect queue and match output in new chunks

Treat an empty connectScriptIds array as an explicit cleared queue instead
of re-migrating from snippet targets, and only fire onOutput triggers when
the latest terminal output contains the pattern.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): require fresh output overlap for onOutput triggers

Only fire output-matched scripts when the regex match extends into the
latest terminal chunk, preventing reruns from stale buffer text.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): promote manual scripts added to host connect queue

Diff connect queue changes from raw connectScriptIds so saving a host
updates manual scripts to onConnect when they are newly queued.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): dedupe output triggers by match position

Track the buffer end offset of each output trigger match and ignore
stale re-scans, with a longer wait for run registration before retry.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): record output trigger matches only after run starts

Propagate automation launch failures to output triggers and commit match
dedupe only once the session run is registered as active.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): address Codex review on wait cursor and sensitive codegen

Track scan offset so waitFor/waitForAny only match output after the previous wait, and emit sendLine after sensitive prompt in recorded scripts.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): harden onOutput triggers against PTY echo and local input

Filter server output before pattern matching so onOutput fires only after
Enter on real stdout, not on keystroke/paste echo, OSC/SGR sequences, or
alternate-screen apps. Add dev diagnostics and scope triggers to the active
session when no explicit host targets are configured.

Co-authored-by: Cursor <cursoragent@cursor.com>

* chore(scripts): remove onOutput trigger debug logging

Drop temporary diagnostics module and console traces now that PTY echo
filtering is verified; keep the production trigger pipeline unchanged.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-28 23:48:12 +08:00

400 lines
16 KiB
TypeScript

/* eslint-disable @typescript-eslint/no-explicit-any */
import { Activity, FolderTree, History, MessageSquare, NotebookText, Palette, PanelLeft, PanelRight, Play, X } from 'lucide-react';
import { buildSidePanelChromeThemeFromTerminalTheme } from '../../infrastructure/theme/terminalAppearanceTokens';
import { injectTerminalLayerChromeSurfaceVars } from '../../infrastructure/theme/terminalAppearanceVars';
import React, { memo, useCallback, useLayoutEffect, useMemo, useRef, useState } from 'react';
import { useActiveTabId } from '../../application/state/activeTabStore';
import {
reorderTerminalSidePanelTab,
TERMINAL_SIDE_PANEL_TAB_IDS,
type TerminalSidePanelTabId,
useTerminalSidePanelTabOrder,
} from '../../application/state/terminalSidePanelTabs';
import { terminalLayoutSuppressStore } from '../../application/state/terminalLayoutSuppressStore';
import { AI_PANEL_FORCE_HIDE_SHELL } from '../ai/aiPanelDiagnostics';
import { Tooltip, TooltipContent, TooltipTrigger } from '../ui/tooltip';
import type { SidePanelTab } from './TerminalLayerSupport';
import { terminalLayerSidePanelStableCtxEqual } from './terminalLayerViewMemo';
import { SidePanelMountedContent } from './terminalLayerSidePanelSlots';
const MemoizedSidePanelMountedContent = memo(
SidePanelMountedContent,
(prev, next) => terminalLayerSidePanelStableCtxEqual(prev.ctx, next.ctx),
);
MemoizedSidePanelMountedContent.displayName = 'MemoizedSidePanelMountedContent';
type SidePanelContext = Record<string, any>;
const SIDE_PANEL_TAB_DRAG_MIME = 'application/x-netcatty-sidepanel-tab';
export function getTerminalSidePanelShellWidth({
activeSidePanelTab,
forceHideAiShell,
isSidePanelOpenForCurrentTab,
resizePreviewWidth,
sidePanelWidth,
}: {
activeSidePanelTab: SidePanelTab | null;
forceHideAiShell: boolean;
isSidePanelOpenForCurrentTab: boolean;
resizePreviewWidth: number | null;
sidePanelWidth: number;
}): number {
if (forceHideAiShell && activeSidePanelTab === 'ai') return 0;
return isSidePanelOpenForCurrentTab
? (resizePreviewWidth ?? sidePanelWidth)
: 0;
}
function hasMountedSidePanelContent(ctx: SidePanelContext): boolean {
const {
mountedAiTabIds,
mountedSftpTabIds,
notesMountedTabIds,
scriptsMountedTabIds,
systemMountedTabIds,
themeMountedTabIds,
sidePanelOpenTabs,
} = ctx;
const anyHistoryOpen = sidePanelOpenTabs instanceof Map
&& Array.from((sidePanelOpenTabs as Map<string, SidePanelTab>).values()).includes('history');
const anyNotesOpen = sidePanelOpenTabs instanceof Map
&& Array.from((sidePanelOpenTabs as Map<string, SidePanelTab>).values()).includes('notes');
return !(
mountedSftpTabIds.length === 0
&& mountedAiTabIds.length === 0
&& notesMountedTabIds.length === 0
&& scriptsMountedTabIds.length === 0
&& systemMountedTabIds.length === 0
&& themeMountedTabIds.length === 0
&& !anyHistoryOpen
&& !anyNotesOpen
);
}
export function TerminalLayerSidePanelSection({ ctx }: { ctx: SidePanelContext }) {
if (!hasMountedSidePanelContent(ctx)) return null;
return <TerminalLayerSidePanelInner ctx={ctx} />;
}
TerminalLayerSidePanelSection.displayName = 'TerminalLayerSidePanelSection';
function TerminalLayerSidePanelInner({ ctx }: { ctx: SidePanelContext }) {
const activeTabId = useActiveTabId();
const sidePanelOpenTabs = ctx.sidePanelOpenTabs as Map<string, SidePanelTab>;
const isSidePanelOpenForCurrentTab = activeTabId ? sidePanelOpenTabs.has(activeTabId) : false;
const activeSidePanelTab = activeTabId ? sidePanelOpenTabs.get(activeTabId) ?? null : null;
const {
Button: Btn,
cn,
followAppTerminalTheme,
handleCloseSidePanel,
handleOpenAI,
handleOpenHistory,
handleOpenNotes,
handleOpenScripts,
handleOpenSystem,
handleOpenTheme,
handleToggleSftpFromBar,
resolvedPreviewTheme,
setSidePanelPosition,
setSidePanelWidth,
persistSidePanelWidth,
sidePanelPosition,
sidePanelWidth,
t,
terminalTheme,
} = ctx;
const [resizePreviewWidth, setResizePreviewWidth] = useState<number | null>(null);
const { sidePanelTabOrder, setSidePanelTabOrder } = useTerminalSidePanelTabOrder();
const sidePanelTheme = useMemo(() => {
const chromeTheme = followAppTerminalTheme
? terminalTheme
: (resolvedPreviewTheme ?? terminalTheme);
return buildSidePanelChromeThemeFromTerminalTheme(chromeTheme);
}, [followAppTerminalTheme, resolvedPreviewTheme, terminalTheme]);
useLayoutEffect(() => {
if (!isSidePanelOpenForCurrentTab) return;
const chromeTheme = followAppTerminalTheme
? terminalTheme
: (resolvedPreviewTheme ?? terminalTheme);
injectTerminalLayerChromeSurfaceVars(chromeTheme);
}, [
followAppTerminalTheme,
isSidePanelOpenForCurrentTab,
resolvedPreviewTheme,
terminalTheme,
]);
const [dragOverSidePanelTab, setDragOverSidePanelTab] = useState<{
tab: TerminalSidePanelTabId;
placement: 'before' | 'after';
} | null>(null);
const draggedSidePanelTabRef = useRef<TerminalSidePanelTabId | null>(null);
const isAiShellForceHidden = AI_PANEL_FORCE_HIDE_SHELL && activeSidePanelTab === 'ai';
const shellWidth = getTerminalSidePanelShellWidth({
activeSidePanelTab,
forceHideAiShell: AI_PANEL_FORCE_HIDE_SHELL,
isSidePanelOpenForCurrentTab,
resizePreviewWidth,
sidePanelWidth,
});
const handleSidePanelResizeStart = useCallback((event: React.MouseEvent) => {
if (!isSidePanelOpenForCurrentTab) return;
event.preventDefault();
terminalLayoutSuppressStore.begin();
const startX = event.clientX;
const startWidth = sidePanelWidth;
let lastWidth = startWidth;
let rafId: number | null = null;
const onMouseMove = (moveEvent: MouseEvent) => {
const delta = moveEvent.clientX - startX;
lastWidth = Math.max(
280,
Math.min(800, startWidth + (sidePanelPosition === 'left' ? delta : -delta)),
);
if (rafId !== null) return;
rafId = requestAnimationFrame(() => {
rafId = null;
setResizePreviewWidth(lastWidth);
});
};
const onMouseUp = () => {
if (rafId !== null) cancelAnimationFrame(rafId);
setSidePanelWidth(lastWidth);
persistSidePanelWidth(lastWidth);
setResizePreviewWidth(null);
terminalLayoutSuppressStore.end();
window.removeEventListener('mousemove', onMouseMove);
window.removeEventListener('mouseup', onMouseUp);
};
window.addEventListener('mousemove', onMouseMove);
window.addEventListener('mouseup', onMouseUp);
}, [
isSidePanelOpenForCurrentTab,
persistSidePanelWidth,
setSidePanelWidth,
sidePanelPosition,
sidePanelWidth,
]);
const handleSidePanelTabDragStart = useCallback((event: React.DragEvent, tab: TerminalSidePanelTabId) => {
draggedSidePanelTabRef.current = tab;
setDragOverSidePanelTab(null);
event.dataTransfer.effectAllowed = 'move';
event.dataTransfer.setData(SIDE_PANEL_TAB_DRAG_MIME, tab);
event.dataTransfer.setData('text/plain', tab);
}, []);
const handleSidePanelTabDrop = useCallback((event: React.DragEvent, targetTab: TerminalSidePanelTabId) => {
if (!Array.from(event.dataTransfer.types).includes(SIDE_PANEL_TAB_DRAG_MIME)) return;
event.preventDefault();
const transferredTab = event.dataTransfer.getData(SIDE_PANEL_TAB_DRAG_MIME) as TerminalSidePanelTabId;
const draggedTab = draggedSidePanelTabRef.current ?? transferredTab;
draggedSidePanelTabRef.current = null;
setDragOverSidePanelTab(null);
if (!TERMINAL_SIDE_PANEL_TAB_IDS.has(draggedTab)) return;
const nextOrder = reorderTerminalSidePanelTab(
sidePanelTabOrder,
draggedTab,
targetTab,
dragOverSidePanelTab?.tab === targetTab ? dragOverSidePanelTab.placement : 'before',
);
if (nextOrder !== sidePanelTabOrder) {
setSidePanelTabOrder(nextOrder);
}
}, [dragOverSidePanelTab, setSidePanelTabOrder, sidePanelTabOrder]);
const handleSidePanelTabDragOver = useCallback((event: React.DragEvent, targetTab: TerminalSidePanelTabId) => {
if (!Array.from(event.dataTransfer.types).includes(SIDE_PANEL_TAB_DRAG_MIME)) return;
event.preventDefault();
event.dataTransfer.dropEffect = 'move';
const rect = event.currentTarget.getBoundingClientRect();
const placement = event.clientX > rect.left + (rect.width / 2) ? 'after' : 'before';
setDragOverSidePanelTab((current) => {
if (current?.tab === targetTab && current.placement === placement) return current;
return { tab: targetTab, placement };
});
}, []);
const handleSidePanelTabDragLeave = useCallback((event: React.DragEvent, targetTab: TerminalSidePanelTabId) => {
if (dragOverSidePanelTab?.tab !== targetTab) return;
const nextTarget = event.relatedTarget as Node | null;
if (nextTarget && event.currentTarget.contains(nextTarget)) return;
setDragOverSidePanelTab(null);
}, [dragOverSidePanelTab]);
const sidePanelTabItems = useMemo(() => [
{ id: 'sftp' as const, label: t('terminal.layer.sftp'), icon: <FolderTree size={15} />, onClick: handleToggleSftpFromBar },
{ id: 'scripts' as const, label: t('terminal.layer.scripts'), icon: <Play size={15} />, onClick: handleOpenScripts },
{ id: 'history' as const, label: t('terminal.layer.history'), icon: <History size={15} />, onClick: handleOpenHistory },
{ id: 'theme' as const, label: t('terminal.layer.theme'), icon: <Palette size={15} />, onClick: handleOpenTheme },
{ id: 'system' as const, label: t('terminal.layer.system'), icon: <Activity size={15} />, onClick: handleOpenSystem },
{ id: 'notes' as const, label: t('terminal.layer.notes'), icon: <NotebookText size={15} />, onClick: handleOpenNotes },
{ id: 'ai' as const, label: t('terminal.layer.aiChat'), icon: <MessageSquare size={15} />, onClick: handleOpenAI },
], [
handleOpenAI,
handleOpenHistory,
handleOpenNotes,
handleOpenScripts,
handleOpenSystem,
handleOpenTheme,
handleToggleSftpFromBar,
t,
]);
const sidePanelTabItemById = useMemo(
() => new Map(sidePanelTabItems.map((item) => [item.id, item])),
[sidePanelTabItems],
);
return (
<div
style={{ width: shellWidth, contain: 'layout paint style' }}
className={cn(
'flex-shrink-0 h-full relative z-20',
shellWidth === 0 && 'overflow-hidden',
sidePanelPosition === 'right' && 'order-last',
)}
data-section="terminal-side-panel-shell"
data-side-panel-position={sidePanelPosition}
>
{isSidePanelOpenForCurrentTab && !isAiShellForceHidden && (
<div
className={cn(
'absolute top-0 h-full w-2 cursor-ew-resize z-30',
sidePanelPosition === 'left' ? 'right-[-3px]' : 'left-[-3px]',
)}
data-section="terminal-side-panel-resizer"
onMouseDown={handleSidePanelResizeStart}
/>
)}
<div
className={cn(
'h-full flex flex-col overflow-hidden',
!isSidePanelOpenForCurrentTab && 'pointer-events-none',
)}
data-section={isSidePanelOpenForCurrentTab ? 'terminal-side-panel' : undefined}
data-open={isSidePanelOpenForCurrentTab ? 'true' : 'false'}
data-side-panel-tab={isSidePanelOpenForCurrentTab ? (activeSidePanelTab ?? undefined) : undefined}
style={{
backgroundColor: sidePanelTheme.termBg,
color: sidePanelTheme.termFg,
...(isSidePanelOpenForCurrentTab && sidePanelPosition === 'left'
? { borderRight: `1px solid ${sidePanelTheme.separator}` }
: {}),
...(isSidePanelOpenForCurrentTab && sidePanelPosition === 'right'
? { borderLeft: `1px solid ${sidePanelTheme.separator}` }
: {}),
}}
>
{isSidePanelOpenForCurrentTab && !isAiShellForceHidden && (
<div
className="flex h-9 items-center px-1.5 py-1 flex-shrink-0 gap-1"
data-section="terminal-side-panel-tabs"
style={{
backgroundColor: sidePanelTheme.termBg,
borderBottom: `1px solid ${sidePanelTheme.separator}`,
}}
>
{sidePanelTabOrder.map((tabId) => {
const item = sidePanelTabItemById.get(tabId);
if (!item) return null;
const isActive = activeSidePanelTab === item.id;
const showDropIndicator = dragOverSidePanelTab?.tab === item.id
&& draggedSidePanelTabRef.current !== null
&& draggedSidePanelTabRef.current !== item.id;
return (
<Tooltip key={item.id}>
<TooltipTrigger asChild>
<Btn
variant="ghost"
size="icon"
draggable
data-tab-id={item.id}
data-tab-type="sidepanel"
data-state={isActive ? 'active' : 'inactive'}
className="netcatty-tab relative h-7 w-7 rounded-md p-0 hover:bg-transparent"
style={{
backgroundColor: isActive
? `color-mix(in srgb, ${sidePanelTheme.accent} 24%, transparent)`
: 'transparent',
color: isActive
? sidePanelTheme.termFg
: sidePanelTheme.mutedFg,
}}
onClick={item.onClick}
onDragStart={(event: React.DragEvent) => handleSidePanelTabDragStart(event, item.id)}
onDragOver={(event: React.DragEvent) => handleSidePanelTabDragOver(event, item.id)}
onDragLeave={(event: React.DragEvent) => handleSidePanelTabDragLeave(event, item.id)}
onDrop={(event: React.DragEvent) => handleSidePanelTabDrop(event, item.id)}
onDragEnd={() => {
draggedSidePanelTabRef.current = null;
setDragOverSidePanelTab(null);
}}
>
{showDropIndicator && (
<span
aria-hidden="true"
className={cn(
'pointer-events-none absolute top-1 bottom-1 w-0.5 rounded-none',
dragOverSidePanelTab?.placement === 'after' ? 'right-0' : 'left-0',
)}
style={{ backgroundColor: sidePanelTheme.accent }}
/>
)}
{item.icon}
</Btn>
</TooltipTrigger>
<TooltipContent>{item.label}</TooltipContent>
</Tooltip>
);
})}
<div className="flex-1" />
<Tooltip>
<TooltipTrigger asChild>
<Btn
variant="ghost"
size="icon"
className="h-7 w-7 rounded-md p-0 hover:bg-transparent"
style={{ color: sidePanelTheme.mutedFg }}
onClick={() => setSidePanelPosition((p: 'left' | 'right') => (p === 'left' ? 'right' : 'left'))}
>
{sidePanelPosition === 'left' ? <PanelRight size={15} /> : <PanelLeft size={15} />}
</Btn>
</TooltipTrigger>
<TooltipContent>
{sidePanelPosition === 'left' ? t('terminal.layer.movePanelRight') : t('terminal.layer.movePanelLeft')}
</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<Btn
variant="ghost"
size="icon"
className="h-7 w-7 rounded-md p-0 hover:bg-transparent"
style={{ color: sidePanelTheme.mutedFg }}
onClick={handleCloseSidePanel}
>
<X size={15} />
</Btn>
</TooltipTrigger>
<TooltipContent>{t('terminal.layer.closePanel')}</TooltipContent>
</Tooltip>
</div>
)}
<div className="flex-1 min-h-0 relative" data-section="terminal-side-panel-content">
<MemoizedSidePanelMountedContent ctx={ctx} />
</div>
</div>
</div>
);
}