Netcatty/components/HostDetailsPanel.proxyProfile.test.tsx

import test from "node:test";
import assert from "node:assert/strict";
import React from "react";
import { renderToStaticMarkup } from "react-dom/server";

import { I18nProvider } from "../application/i18n/I18nProvider.tsx";
import type { Host, Identity } from "../types.ts";
import HostDetailsPanel, { parseOptionalPortInput } from "./HostDetailsPanel.tsx";
import {
  prepareProxyConfigForSave,
  prepareTelnetCredentialsForSave,
  resolvePrimaryProtocolSavePort,
  resolvePrimaryProtocolSwitchPort,
  validateProxyConfigForSave,
} from "./HostDetailsPanel.helpers.ts";
import { TooltipProvider } from "./ui/tooltip.tsx";

const hostWithMissingProxyProfile: Host = {
  id: "host-1",
  label: "DB",
  hostname: "db.example.com",
  username: "root",
  tags: [],
  os: "linux",
  port: 22,
  protocol: "ssh",
  authMethod: "password",
  proxyProfileId: "missing-proxy",
  createdAt: 1,
};

const renderHostDetails = (
  initialData: Host = hostWithMissingProxyProfile,
  options: { identities?: Identity[] } = {},
) =>
  renderToStaticMarkup(
    React.createElement(
      I18nProvider,
      { locale: "en" },
      React.createElement(
        TooltipProvider,
        null,
        React.createElement(HostDetailsPanel, {
          initialData,
          availableKeys: [],
          identities: options.identities ?? [],
          proxyProfiles: [],
          groups: [],
          managedSources: [],
          allTags: [],
          allHosts: [],
          terminalThemeId: "default",
          terminalFontSize: 14,
          onSave: () => {},
          onCancel: () => {},
        }),
      ),
    ),
  );

const findInputByValue = (markup: string, value: string) => {
  const match = markup.match(new RegExp(`<input(?=[^>]*value="${value}")[^>]*>`));
  assert.ok(match, `expected input with value ${value}`);
  return match[0];
};

const classTokens = (markup: string) => {
  const classMatch = markup.match(/class="([^"]*)"/);
  assert.ok(classMatch, "expected class attribute");
  return new Set(classMatch[1].split(/\s+/).filter(Boolean));
};

test("HostDetailsPanel shows a missing saved proxy without undefined fields", () => {
  const markup = renderHostDetails();

  assert.match(markup, /Missing saved proxy/);
  assert.doesNotMatch(markup, /undefined:undefined/);
});

test("HostDetailsPanel labels command proxy summaries consistently", () => {
  const markup = renderHostDetails({
    ...hostWithMissingProxyProfile,
    proxyProfileId: undefined,
    proxyConfig: {
      type: "command",
      host: "",
      port: 0,
      command: "cloudflared access ssh --hostname %h --token secret",
    },
  });

  assert.match(markup, /ProxyCommand/);
  assert.doesNotMatch(markup, /COMMAND/);
  assert.doesNotMatch(markup, /cloudflared access ssh/);
  assert.doesNotMatch(markup, /secret/);
});

test("HostDetailsPanel keeps explicitly cleared telnet credentials empty", () => {
  const markup = renderHostDetails({
    ...hostWithMissingProxyProfile,
    protocol: "telnet",
    telnetEnabled: true,
    telnetPort: 23,
    username: "root",
    password: "ssh-password",
    telnetUsername: "",
    telnetPassword: "",
    proxyProfileId: undefined,
  });

  assert.match(markup, /placeholder="Telnet Username"[^>]*value=""/);
  assert.match(markup, /placeholder="Telnet Password"[^>]*value=""/);
  assert.doesNotMatch(markup, /placeholder="Telnet Username"[^>]*value="root"/);
  assert.doesNotMatch(markup, /placeholder="Telnet Password"[^>]*value="ssh-password"/);
});

test("HostDetailsPanel shows a selected telnet identity instead of manual telnet fields", () => {
  const markup = renderHostDetails(
    {
      ...hostWithMissingProxyProfile,
      protocol: "telnet",
      telnetEnabled: true,
      identityId: "ssh-identity",
      telnetIdentityId: "telnet-identity",
      telnetUsername: undefined,
      telnetPassword: undefined,
      proxyProfileId: undefined,
    },
    {
      identities: [{
        id: "ssh-identity",
        label: "SSH login",
        username: "ssh-user",
        authMethod: "password",
        password: "ssh-password",
        created: 1,
      }, {
        id: "telnet-identity",
        label: "Telnet login",
        username: "telnet-user",
        authMethod: "password",
        password: "telnet-password",
        created: 2,
      }],
    },
  );

  assert.match(markup, /telnet-user - Telnet login/);
  assert.doesNotMatch(markup, /placeholder="Telnet Username"/);
  assert.doesNotMatch(markup, /placeholder="Telnet Password"/);
});

test("prepareTelnetCredentialsForSave preserves selected telnet identity and clears manual telnet fields", () => {
  const saved = prepareTelnetCredentialsForSave({
    ...hostWithMissingProxyProfile,
    protocol: "telnet",
    telnetEnabled: true,
    identityId: "ssh-identity",
    telnetIdentityId: "telnet-identity",
    telnetUsername: "stale-telnet-user",
    telnetPassword: "stale-telnet-password",
    proxyProfileId: undefined,
  });

  assert.equal(saved.identityId, "ssh-identity");
  assert.equal(saved.telnetIdentityId, "telnet-identity");
  assert.equal(saved.telnetUsername, undefined);
  assert.equal(saved.telnetPassword, undefined);
});

test("HostDetailsPanel disables save when hostname is whitespace only", () => {
  const markup = renderHostDetails({
    ...hostWithMissingProxyProfile,
    hostname: "   ",
    proxyProfileId: undefined,
  });

  assert.match(markup, /<button[^>]*disabled=""[^>]*aria-label="Save"/);
  assert.match(markup, />Save<\/button>/);
  assert.match(markup, /<button[^>]*disabled=""[^>]*>Save<\/button>/);
});

test("HostDetailsPanel gives the telnet port field the same roomy layout as SSH", () => {
  const markup = renderHostDetails({
    ...hostWithMissingProxyProfile,
    protocol: "telnet",
    telnetEnabled: true,
    telnetPort: 2325,
    proxyProfileId: undefined,
  });

  const telnetMarkup = markup.slice(markup.indexOf("Telnet on"));
  const wrapperMatch = telnetMarkup.match(/<div class="([^"]*w-1\/2[^"]*)"/);
  assert.ok(wrapperMatch, "expected telnet port wrapper");
  const wrapperClasses = new Set(wrapperMatch[1].split(/\s+/).filter(Boolean));
  assert.ok(wrapperClasses.has("ml-auto"));
  assert.ok(wrapperClasses.has("w-1/2"));
  assert.ok(wrapperClasses.has("min-w-0"));
  assert.ok(wrapperClasses.has("justify-end"));
  const telnetPortInput = findInputByValue(markup, "2325");
  const inputClasses = classTokens(telnetPortInput);
  assert.ok(inputClasses.has("flex-1"));
  assert.ok(inputClasses.has("min-w-0"));
  assert.ok(inputClasses.has("text-center"));
  assert.equal(inputClasses.has("w-16"), false);
});

test("HostDetailsPanel displays inherited telnet port before falling back to 23", () => {
  const markup = renderToStaticMarkup(
    React.createElement(
      I18nProvider,
      { locale: "en" },
      React.createElement(
        TooltipProvider,
        null,
        React.createElement(HostDetailsPanel, {
          initialData: {
            ...hostWithMissingProxyProfile,
            protocol: "telnet",
            telnetEnabled: true,
            telnetPort: undefined,
            port: undefined,
            group: "network",
            proxyProfileId: undefined,
          },
          availableKeys: [],
          identities: [],
          proxyProfiles: [],
          groups: ["network"],
          managedSources: [],
          allTags: [],
          allHosts: [],
          terminalThemeId: "default",
          terminalFontSize: 14,
          groupConfigs: [{ path: "network", telnetPort: 2325 }],
          onSave: () => {},
          onCancel: () => {},
        }),
      ),
    ),
  );

  assert.match(findInputByValue(markup, "2325"), /type="number"/);
});

test("HostDetailsPanel uses group telnet port instead of ssh port for optional telnet", () => {
  const markup = renderToStaticMarkup(
    React.createElement(
      I18nProvider,
      { locale: "en" },
      React.createElement(
        TooltipProvider,
        null,
        React.createElement(HostDetailsPanel, {
          initialData: {
            ...hostWithMissingProxyProfile,
            protocol: "ssh",
            telnetEnabled: true,
            telnetPort: undefined,
            port: 2222,
            group: "network",
            proxyProfileId: undefined,
          },
          availableKeys: [],
          identities: [],
          proxyProfiles: [],
          groups: ["network"],
          managedSources: [],
          allTags: [],
          allHosts: [],
          terminalThemeId: "default",
          terminalFontSize: 14,
          groupConfigs: [{ path: "network", telnetPort: 2325 }],
          onSave: () => {},
          onCancel: () => {},
        }),
      ),
    ),
  );

  const telnetMarkup = markup.slice(markup.indexOf("Telnet on"));
  assert.match(findInputByValue(telnetMarkup, "2325"), /type="number"/);
  assert.doesNotMatch(telnetMarkup, /value="2222"/);
});

test("HostDetailsPanel displays inherited telnet credentials", () => {
  const markup = renderToStaticMarkup(
    React.createElement(
      I18nProvider,
      { locale: "en" },
      React.createElement(
        TooltipProvider,
        null,
        React.createElement(HostDetailsPanel, {
          initialData: {
            ...hostWithMissingProxyProfile,
            protocol: "telnet",
            telnetEnabled: true,
            telnetUsername: undefined,
            telnetPassword: undefined,
            username: "ssh-user",
            password: "ssh-password",
            group: "network",
            proxyProfileId: undefined,
          },
          availableKeys: [],
          identities: [],
          proxyProfiles: [],
          groups: ["network"],
          managedSources: [],
          allTags: [],
          allHosts: [],
          terminalThemeId: "default",
          terminalFontSize: 14,
          groupConfigs: [{
            path: "network",
            telnetUsername: "group-telnet-user",
            telnetPassword: "group-telnet-password",
          }],
          onSave: () => {},
          onCancel: () => {},
        }),
      ),
    ),
  );

  assert.match(markup, /placeholder="Telnet Username"[^>]*value="group-telnet-user"/);
  assert.match(markup, /placeholder="Telnet Password"[^>]*value="group-telnet-password"/);
  assert.doesNotMatch(markup, /placeholder="Telnet Username"[^>]*value="ssh-user"/);
  assert.doesNotMatch(markup, /placeholder="Telnet Password"[^>]*value="ssh-password"/);
});

test("parseOptionalPortInput clears empty port values", () => {
  assert.equal(parseOptionalPortInput(""), undefined);
  assert.equal(parseOptionalPortInput("2325"), 2325);
});

test("validateProxyConfigForSave rejects missing proxy identities", () => {
  assert.equal(
    validateProxyConfigForSave({
      proxyConfig: {
        type: "http",
        host: "proxy.example.com",
        port: 3128,
        identityId: "missing-identity",
      },
      identities: [],
    }),
    "missingIdentity",
  );
});

test("validateProxyConfigForSave rejects missing identities inside saved proxy profiles", () => {
  assert.equal(
    validateProxyConfigForSave({
      proxyProfileId: "profile-1",
      proxyProfiles: [{
        id: "profile-1",
        label: "Office Proxy",
        config: {
          type: "http",
          host: "proxy.example.com",
          port: 3128,
          identityId: "missing-identity",
        },
        createdAt: 1,
      }],
      identities: [],
    }),
    "missingIdentity",
  );
});

test("validateProxyConfigForSave rejects incomplete proxy identities", () => {
  assert.equal(
    validateProxyConfigForSave({
      proxyConfig: {
        type: "http",
        host: "proxy.example.com",
        port: 3128,
        identityId: "identity-1",
      },
      identities: [{
        id: "identity-1",
        label: "Proxy login",
        username: "proxy-user",
        authMethod: "password",
        created: 1,
      }],
    }),
    "incompleteIdentity",
  );
});

test("validateProxyConfigForSave rejects unreadable proxy identity passwords", () => {
  assert.equal(
    validateProxyConfigForSave({
      proxyConfig: {
        type: "http",
        host: "proxy.example.com",
        port: 3128,
        identityId: "identity-1",
      },
      identities: [{
        id: "identity-1",
        label: "Proxy login",
        username: "proxy-user",
        authMethod: "password",
        password: "enc:v1:djEwdGVzdAAAAAAAAAAAAAAAAA==",
        created: 1,
      }],
    }),
    "unreadableIdentity",
  );
});

test("prepareProxyConfigForSave returns a normalized proxy config for save handlers", () => {
  assert.deepEqual(
    prepareProxyConfigForSave({
      proxyConfig: {
        type: "http",
        host: " proxy.example.com ",
        port: "3128" as never,
        command: "cloudflared access ssh --hostname %h --token secret",
        username: " proxy-user ",
        password: "proxy-secret",
      },
      identities: [],
    }),
    {
      normalizedProxyConfig: {
        type: "http",
        host: "proxy.example.com",
        port: 3128,
        username: "proxy-user",
        password: "proxy-secret",
      },
    },
  );
});

test("prepareProxyConfigForSave returns identity errors before save handlers build output", () => {
  assert.deepEqual(
    prepareProxyConfigForSave({
      proxyProfileId: "profile-1",
      proxyProfiles: [{
        id: "profile-1",
        label: "Office Proxy",
        config: {
          type: "http",
          host: "proxy.example.com",
          port: 3128,
          identityId: "identity-1",
        },
        createdAt: 1,
      }],
      identities: [{
        id: "identity-1",
        label: "Proxy login",
        username: "",
        authMethod: "password",
        password: "enc:v1:djEwdGVzdAAAAAAAAAAAAAAAAA==",
        created: 1,
      }],
    }),
    { error: "incompleteIdentity" },
  );
});

test("resolvePrimaryProtocolSwitchPort only migrates opposite protocol defaults", () => {
  assert.equal(resolvePrimaryProtocolSwitchPort(22, "telnet", false, false), 23);
  assert.equal(resolvePrimaryProtocolSwitchPort(23, "ssh", false, false), 22);
  assert.equal(resolvePrimaryProtocolSwitchPort(2222, "telnet", false, false), 2222);
  assert.equal(resolvePrimaryProtocolSwitchPort(2323, "ssh", false, false), 2323);
  assert.equal(resolvePrimaryProtocolSwitchPort(undefined, "telnet", false, false), 23);
  assert.equal(resolvePrimaryProtocolSwitchPort(undefined, "ssh", false, false), 22);
  assert.equal(resolvePrimaryProtocolSwitchPort(22, "telnet", false, true), 22);
  assert.equal(resolvePrimaryProtocolSwitchPort(22, "telnet", true, false), 22);
});

test("resolvePrimaryProtocolSavePort falls back to telnet default for primary telnet", () => {
  assert.equal(resolvePrimaryProtocolSavePort("telnet", undefined, false, false), 23);
  assert.equal(resolvePrimaryProtocolSavePort("telnet", 2323, false, false), 2323);
  assert.equal(resolvePrimaryProtocolSavePort("ssh", undefined, false, false), 22);
  assert.equal(resolvePrimaryProtocolSavePort("ssh", undefined, true, false), undefined);
  assert.equal(resolvePrimaryProtocolSavePort("telnet", undefined, false, true), undefined);
  assert.equal(resolvePrimaryProtocolSavePort("telnet", undefined, true, false), undefined);
});

test("HostDetailsPanel does not offer to disable telnet when telnet is the primary protocol", () => {
  const markup = renderHostDetails({
    ...hostWithMissingProxyProfile,
    protocol: "telnet",
    telnetEnabled: true,
    telnetPort: 23,
    proxyProfileId: undefined,
  });
  const telnetHeader = markup.match(/Telnet on[\s\S]*?Credentials/);

  assert.ok(telnetHeader);
  assert.doesNotMatch(telnetHeader[0], /hover:text-destructive/);
});

test("HostDetailsPanel shows color and icon controls in the connection settings", () => {
  const markup = renderHostDetails({
    ...hostWithMissingProxyProfile,
    proxyProfileId: undefined,
    distroMode: "manual",
    manualDistro: "linux",
    iconColorMode: "manual",
    iconColor: "blue",
  });

  assert.match(markup, /Color &amp; Icon/);
  assert.match(markup, /Manual icon/);
  assert.match(markup, /Generic Linux/);
  assert.match(markup, /Icon color/);
  assert.match(markup, /Blue/);
  assert.match(markup, /IP or Hostname/);
});

test("HostDetailsPanel keeps empty notes collapsed below connection settings", () => {
  const markup = renderHostDetails({
    ...hostWithMissingProxyProfile,
    proxyProfileId: undefined,
    notes: "",
  });

  assert.match(markup, /aria-label="Show notes editor"/);
  assert.doesNotMatch(markup, /placeholder="Hardware, project, customer, region, role\.\.\."/);
  assert.ok(
    markup.indexOf("IP or Hostname") < markup.indexOf("Notes"),
    "expected notes to render after connection settings",
  );
});

test("HostDetailsPanel expands notes when the host already has notes", () => {
  const markup = renderHostDetails({
    ...hostWithMissingProxyProfile,
    proxyProfileId: undefined,
    notes: "Runs nightly backups",
  });

  assert.match(markup, /aria-label="Hide notes editor"/);
  assert.match(markup, /Runs nightly backups/);
  assert.match(markup, /placeholder="Hardware, project, customer, region, role\.\.\."/);
  assert.ok(
    markup.indexOf("IP or Hostname") < markup.indexOf("Notes"),
    "expected notes to render after connection settings",
  );
});